Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps, cpp): update ms-vscode.cmake-tools #497

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

philips-software-forest-releaser[bot]
Copy link
Contributor

Note

Before merging this PR, please conduct a manual test checking basic functionality of the updated plug-ins. There are no automated tests for the VS Code Extension updates.

Updates ms-vscode.cmake-tools from 1.18.42 to 1.18.43

Release notes

1.18.43

Features:

  • Upgrade cmake_minimum_required version 3.0.0 -> 3.5.0. #3793

Improvements:

  • Add setting for deleting entire build dir when clean configuring. #3515

Bug Fixes:

  • Fix issue "Logs are unavailable when running tests from the Test Explorer" and display properly the test output. #3140
  • Fix issue with "Test Results Not Found" when cmake.ctest.allowParallelJobs is disabled. #3798
  • Update localized strings for Project Status UI and quick pick dropdowns. #3803, #3802
  • Fix issue where new presets couldn't inherit from presets in CmakeUserPresets.json. These presets are now added to CmakeUserPresets.json instead of CmakePresets.json. #3725
  • Fix issue where CMakeTools does not recheck CMake Path to see if user installed CMake after launching VS Code. 3811
  • Fix issue where cmake.buildToolArgs was sometimes applied incorrectly when presets are used #3754
  • Fix issue where preferredGenerator.platform and preferredGenerator.toolset wasn't being compared between the old and new kit to trigger a clean configure on a kit selection change. #2699
  • Still allow for users to add --warn-unused-cli. Now instead of overriding, it will remove our default --no-warn-unused-cli. #1090
  • Ensure useCMakePresets context is set after making a CMakePreset.json with Quick Start. #3734

@philips-software-forest-releaser philips-software-forest-releaser bot requested a review from a team as a code owner July 12, 2024 02:39
@philips-software-forest-releaser philips-software-forest-releaser bot added dependencies Pull requests that update a dependency file vscode-extensions labels Jul 12, 2024
Copy link

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:1bb2cd6fced7b885728c7df111fa00ddb8a3b428bd7021975ed80647939cf402

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 432.86M 1.55K (+0.00%)
linux/arm64 572.09M 572.09M 664.00 (+0.00%)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 15 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.56s
✅ JSON prettier 11 0 0 0.57s
✅ JSON v8r 10 0 4.32s
✅ MARKDOWN markdownlint 8 0 0 1.0s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.24s
✅ REPOSITORY checkov yes no 15.31s
✅ REPOSITORY gitleaks yes no 0.37s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.15s
✅ REPOSITORY secretlint yes no 1.27s
✅ REPOSITORY trivy yes no 6.84s
✅ REPOSITORY trivy-sbom yes no 1.32s
✅ REPOSITORY trufflehog yes no 3.34s
✅ SPELL lychee 48 0 0.97s
✅ YAML prettier 20 0 0 0.95s
✅ YAML v8r 20 0 15.85s
✅ YAML yamllint 20 0 0.46s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:15e907d2f2b0fce81a09fe2595f08c75d95aa8e84e8ee1cdc432601abcac0243

OS/Platform Previous Size Current Size Delta
linux/amd64 640.66M 640.74M 81.64K (+0.01%)
linux/arm64 633.02M 633.10M 85.64K (+0.01%)

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   50s ⏱️ -1s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 68de600. ± Comparison against base commit 1e76851.

@rjaegers rjaegers added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 3fbcac4 Jul 12, 2024
17 checks passed
@rjaegers rjaegers deleted the feature/update-vscode-extensions branch July 12, 2024 09:24
Copy link
Contributor

Pull Request Report (#497)

Static measures

Description Value
Number of added lines 1
Number of deleted lines 1
Number of changed files 1
Number of commits 1
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 6.7 Hours
Time that was spend on the branch before the PR was created 2 Sec
Time that was spend on the branch before the PR was merged 6.7 Hours
Time to merge after last review 3.9 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 13.8 Min
Total time spend in last status check run on PR 5.2 Min

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.1.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file vscode-extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant