Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions. #54

Closed
audreytoskin opened this issue Feb 19, 2017 · 7 comments
Closed

Update installation instructions. #54

audreytoskin opened this issue Feb 19, 2017 · 7 comments

Comments

@audreytoskin
Copy link
Contributor

audreytoskin commented Feb 19, 2017

The README could use some updating.

For example, it offers a long list of shell commands that I think is unnecessary, since you have a Makefile.

Also, I think the note about disabling the GNOME Shell version compatibility check in gsettings might be obsolete. Shell version compatibility checks are disabled by default as of GNOME 3.22 (this link actually appears in the gsettings paragraph). And metadata.json explicitly states compatibility with all versions of GNOME as far back as 3.16. So it seems to me that keeping the compatibility check is a good thing for even older versions of GNOME, and disabling the check is unnecessary for newer versions... Unless TopIcons Plus would actually work with versions of GNOME before 3.16.

If you agree, I can take care of these rewrites for you, if you like.

@phocean
Copy link
Owner

phocean commented Feb 20, 2017

Sure, it has been a long overdue I am always postponing. :-(
If you can push a merge request with some changes, I would happily review and accept it.

Thank you! :-)

@audreytoskin
Copy link
Contributor Author

the credits section provides a link for the original TopIcons extension, but the URL no longer works. It's an IP address rather than a domain name. It responds to ping, but does not respond to my web browser at all, not even a 404 or 501 or whatever.

@audreytoskin
Copy link
Contributor Author

...Is there an alternate domain we could use?

@phocean
Copy link
Owner

phocean commented Feb 21, 2017

No, the original author has not given any sign of life for years. I could never contact him.
That is actually the main reason of my fork.
So let's just remove the URL.

@audreytoskin
Copy link
Contributor Author

Okay, done.

Two more points:

  1. The changelog is out of date too, but it also only has notes about one release. Is this something that we want to update too, or should it just be removed?
  2. I can't really comment on the Known Issues section, since I haven't used Dropbox in a long time. I could install Dropbox for the purpose of testing its Legacy Tray icon, but if you already use Dropbox, it would be easier if you did it.

@phocean
Copy link
Owner

phocean commented Feb 22, 2017

Great :-)

  1. No, it was created before I start using github releases. Now the chanlog can be found in the releases. Let's remove it.
  2. I haven't had any issue with Dropbox anymore, so let's remove it too. Instead, I would refer put the GDK_BACKEND tip and point to issue TopIcons-plus does not display icon XXX #47, as it is something that will happen more and more with a growing Wayland user base.

@phocean
Copy link
Owner

phocean commented Feb 24, 2017

Thank you @terrycloth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants