fix issue#71 #101
Merged
fix issue#71 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phodal
reviewed
Apr 11, 2020
src/app/app.component.html
Outdated
| </mat-menu> | ||
| <button mat-button [matMenuTriggerFor]="appMenu"> | ||
| 资源<mat-icon>arrow_drop_down</mat-icon> | ||
| <div class="header"> |
There was a problem hiding this comment.
如果是加在这里的话，应该是要叫 app-header 或者 nav-bar 不能叫 header，header 是一个非常宽泛的命名，容易引起歧义，引发 CSS 冲突 。
There was a problem hiding this comment.
如果是加在这里的话，应该是要叫
app-header或者nav-bar不能叫header，header是一个非常宽泛的命名，容易引起歧义，引发 CSS 冲突 。
好的
phodal
added a commit
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.