Empty errors with two level nested form using version 4.5.0

[alejandrodevs]

I was using version 4.4.3 version and everything was working fine. After I migrated to version 4.5.0 the errors in the deepest nested form weren't shown.

Example:

<.form for={@form} phx-submit={@action}>
    … Errors shown correctly after submit.

    <.inputs_for :let={nested_1} field={@form[:nested_1]}>
        … Errors shown correctly after submit.

        <.inputs_for :let={nested_2} field={nested_1[:nested_2]}>
            … Errors are empty and not showing correctly after submit.
        </.inputs_for>
    </.inputs_for>
</.form>

After checking the latest changes I found this:
a9e1a3d#diff-097986c2a86bfdab8c54b295763f1a6d47b1e86bf91bb9618715fc82b5661269R65

If I am not missing something, this only works with just one level nested form because the parent form action is present. Two-level nested form will not shown the errors because the parent form is the one-level nested form which has action nil.

Any thoughts on this? Should this be setting the action in child nested forms to avoid this?
Please let me know if I am missing something.

[ibarchenkov]

I've stumbled upon the same issue. As you suggested, passing parent_action to the nested forms seem to help, but I'm unaware of the possible implications of adding this line:

action: changeset.action,

here and there.

[nthock]

+1 on facing the same issue in this upgrade

[josevalim]

Can you please try main and let me know? If it works I will ship a new release asap. :)

[johantell]

I can verify that the commit solved the problem for us :)

[nthock]

Also confirmed that this commit solved the problem.

[ibarchenkov]

Works for me as well. Thanks Jose! ❤️

[josevalim]

4.5.1 is out, enjoy! ❤️