New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inputs_form spec #296

Merged

josevalim merged 1 commit into phoenixframework:master from lukaszsamson:ls-fix-inputs-for-spec

Mar 23, 2020

Contributor

lukaszsamson commented Mar 23, 2020

v2.14.11 introduced a regression. Now a valid code

<%= inputs_for f, :my_field, fn f2 -> %>
    <div class="form-group">
      <%= label f2, :name, class: "control-label" %>
      <%= text_input f2, :name, class: "form-control" %>
      <%= error_tag f2, :name %>
    </div>
<% end %>

fails to dialyze with

The function call will not succeed.

Phoenix.HTML.Form.inputs_for(_f :: any(), :my_field, (_ -> {:safe, [any(), ...]}))

breaks the contract
(t(), field(), Keyword.t()) :: [t()]


          fix inputs_form spec

dbd3d34

josevalim merged commit 004bc46 into phoenixframework:master

Member

josevalim commented Mar 23, 2020

💚 💙 💜 💛 ❤️

bcat-eu mentioned this pull request

inputs_for/3 conflicts with inputs_for/4 without optional params #299

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet