Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Cordova from PhoneGap #34

Open
mwbrooks opened this issue Jan 7, 2016 · 33 comments
Open

Decouple Cordova from PhoneGap #34

mwbrooks opened this issue Jan 7, 2016 · 33 comments
Assignees

Comments

@mwbrooks
Copy link
Collaborator

mwbrooks commented Jan 7, 2016

Description

We would like to see PhoneGap (CLI and Desktop) not require a specific version of Cordova. Instead, we would like each app to declare the Cordova version as a dependency. This will allow older apps to lockdown the Cordova version, while still using the latest PhoneGap tools.

Follow

@stevengill
Copy link

To split up cordova-create, it makes sense to split up all fetching code into its own module. I'm currently working on that. Here is the proposal for cordova-fetch: apache/cordova-discuss#33

@mwbrooks
Copy link
Collaborator Author

Had a meeting with Microsoft to get consensus on it.

@mwbrooks
Copy link
Collaborator Author

Progress is being made on a forked branch:
https://github.com/stevengill/cordova-lib/tree/CB-9858

@mwbrooks
Copy link
Collaborator Author

mwbrooks commented Mar 4, 2016

Made some progress this week. Working towards integrating into Cordova Lib behind a flag.

@mwbrooks
Copy link
Collaborator Author

@stevengill when you have a moment, can you drop a brief update on this work.

@mwbrooks
Copy link
Collaborator Author

Plugin and template integration remaining.

@mwbrooks
Copy link
Collaborator Author

@stevengill is back!

@stevengill
Copy link

Lots of discussion has been happening around the fetch proposal and how it is going to work with npm install. Microsoft, IBM and others are chiming in. apache/cordova-discuss#33. Uninstall method was added to cordova-fetch that runs npm uninstall.

@stevengill
Copy link

ready for merge. Tools release this week will include the PR

@mwbrooks
Copy link
Collaborator Author

@stevengill can you update these with the next steps or we can create a new task to track it.

@stevengill
Copy link

Definitely!

After the above are completed (timeline, next week)

  • integrate cordova-create + cordova-fetch into phonegap-create, move forward with adding package.json to phonegap-create if template doesn't have it.

@mwbrooks
Copy link
Collaborator Author

cordova-create has been extracted and will be published today. Next step is getting the CLI to use it.

@mwbrooks
Copy link
Collaborator Author

Publishing cordova-create is held up by a failing test.

We have a branch on PhoneGap that uses the cordova-create module. This is just waiting on the official release.

@mwbrooks
Copy link
Collaborator Author

Team meeting tomorrow to discuss the entire process of packing (bundling) cordova with PhoneGap.

@carynbear
Copy link

@mwbrooks: I added in symlinking and had Suraj review the changes I made to connect this week. The packagejson dependencies require the next minor Common update. But it's ready for testing slash review

https://docs.google.com/document/d/1C_gHnJfc4oqkYqUVA1omrwCHkoxCgi7TEa71-hgNSmI/edit?usp=sharing

@carynbear
Copy link

carynbear commented Aug 8, 2016

@stevengill
Next Steps:

  1. Release Cordova Common minor bump
  2. Review Cordova Create (still one failing test on AppVeyor; added back symlinking)
    2.1 Review Cordova Lib
    2.2 Review Cordova Cli (added back symlinking)
  3. Review Phonegap Cordova Dependence
  4. Review Connect PhoneGap (was already checked out by Suraj)
  5. Review PhoneGap CLI

ToDos:

  • fix package json dependencies as modules get released on npm
  • suite of end-to-end tests (I ran the commands in the phonegap/cordova tutorial to make sure things looked good, but should do some extra careful testing)

@carynbear
Copy link

carynbear commented Aug 11, 2016

(1) Waiting on Cordova-Common 1.4.1 release!
(2) cordova-create PR to fix appveyor test
(2.1) need to publish Cordova-Create on npm
(2.2) cordova-lib PR failing tests
(2.3) cordova-cli PR
(3) Give Phonegap-Cordova-Dependence a new phonegap repo
(3.1) Need to publish Phonegap-Cordova-Dependence on npm.
(4) connect-phonegap PR
(5) phonegap-cli PR for decoupling

@mwbrooks
Copy link
Collaborator Author

Common was released last week. Android, iOS, and create are going out today. See the above list for the next steps.

@mwbrooks
Copy link
Collaborator Author

cordova-create was released and published on Friday. Next up we can review and merge it into the PhoneGap CLI / Desktop.

@stevengill
Copy link

(1) Waiting on Cordova-Common 1.4.1 release!
(2) cordova-create PR to fix appveyor test
(2.1) need to publish Cordova-Create on npm
(2.2) cordova-lib PR failing tests
(2.3) cordova-cli PR
(3) Give Phonegap-Cordova-Dependence a new phonegap repo
(3.1) Need to publish Phonegap-Cordova-Dependence on npm.
(4) connect-phonegap PR
(5) phonegap-cli PR for decoupling

@mwbrooks
Copy link
Collaborator Author

@stevengill is moving along on this. @purplecabbage is going to help look into the connect-phonegap dependence on Cordova.

@stevengill
Copy link

onboarding vishal on this work today. Need to figure out what to do with phonegap-cordova-dependence and then move forward

@maverickmishra
Copy link
Member

The phonegap - cordova decouple plan document .

https://docs.google.com/document/d/1eC3jV0P9eQybn2hQyByIyLXtA-haiSdnD-W3aXQ326o/edit

@stevengill
Copy link

Vishal just shared a document outline changes we are going to make to connect-phonegap so we don't have to phonegap-cordova dependance as its own module anymore and instead have it live in pg-cli.

@mwbrooks
Copy link
Collaborator Author

mwbrooks commented Oct 3, 2016

A lot of discussion happened last week. Looking to remove the dependence module and move the code into the PG CLI. Also moving the browser platform management from connect-phonegap to the phonegap-cli.

@stevengill
Copy link

@maverickmishra, incorporated cordova-phonegap-depandance into pg cli. Adding browser functionality got moved into cli from connect-phonegap.

@mwbrooks
Copy link
Collaborator Author

@maverickmishra moved the browser functionality into the PG CLI and added the test cases by @carynbear. Final tasks are adding browser tests (likely ported from connect-phonegap).

@mwbrooks
Copy link
Collaborator Author

mwbrooks commented Nov 4, 2016

Setting this On Hold since @maverickmishra is away.

@mwbrooks
Copy link
Collaborator Author

@maverickmishra if you have an update can you drop it here. Thanks!

@mwbrooks
Copy link
Collaborator Author

mwbrooks commented Dec 5, 2016

@maverickmishra

  • Starting back into this work
  • Updating since the PG Dev App and latest CLI releases

@mwbrooks
Copy link
Collaborator Author

@maverickmishra

@mwbrooks
Copy link
Collaborator Author

mwbrooks commented Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants