Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons miss fill weight when using Phosphor font #16

Closed
pebly opened this issue Feb 18, 2022 · 3 comments
Closed

Some icons miss fill weight when using Phosphor font #16

pebly opened this issue Feb 18, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pebly
Copy link

pebly commented Feb 18, 2022

Describe the bug
There is a problem when I try to use fill weight for some icons.

To Reproduce

  1. Import Phosphor using the script <script src="https://unpkg.com/phosphor-icons"></script>.
  2. Some icons would not render, for example:
    • <i class="ph-text-bolder-fill"></i>
    • <i class="ph-text-h-fill"></i>

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 98.0.4758.102

Additional context
I didn't try to render all the icons. Extensive research and debugging may be needed to find all the icons that don't render when using the Phosphor by the font.

@pebly pebly added the bug Something isn't working label Feb 18, 2022
@rektdeckard
Copy link
Member

Thanks for the report. I've done some digging, and it looks like we are overflowing the Unicode Private Use Area range in our icon font, and the broken glyphs all happen to align with the codepoints for diacritics, non-printing characters, and other special characters that are not displayed correctly. For visibility, the broken icons as best I can tell are:

Invisible or non-printing

ph-television-simple-fill
ph-tennis-ball-fill
ph-terminal-fill
ph-terminal-window-fill
ph-test-tube-fill
ph-text-aa-fill
ph-text-align-center-fill
ph-text-align-justify-fill
ph-text-align-left-fill
ph-text-align-right-fill
ph-text-bolder-fill
ph-text-h-fill
ph-text-h-five-fill
ph-text-h-four-fill
ph-text-h-one-fill
ph-text-h-six-fill

Offset

ph-tiktok-logo-fill
ph-timer-fill
ph-toggle-left-fill
ph-toggle-right-fill
ph-toilet-fill
ph-toilet-paper-fill
ph-tote-fill
ph-tote-simple-fill
ph-trademark-registered-fill
ph-traffic-cone-fill
ph-traffic-sign-fill
ph-traffic-signal-fill
ph-train-fill

We'll work on a fix, probably by shifting the entire fill weight to another Unicode region.

@pebly
Copy link
Author

pebly commented Mar 1, 2022

That's great, thank you for the response. As a designer myself I love your work with Phosphor!

@rektdeckard
Copy link
Member

This is fixed with phosphor-icons/homepage#221 and is live in @phosphor-icons/web@^2.0.0, the new vanilla JS package 👍

@rektdeckard rektdeckard transferred this issue from phosphor-icons/homepage Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants