Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHPUnit 10 #55

Closed
herndlm opened this issue Feb 13, 2023 · 2 comments
Closed

Support PHPUnit 10 #55

herndlm opened this issue Feb 13, 2023 · 2 comments

Comments

@herndlm
Copy link

herndlm commented Feb 13, 2023 •
edited
Loading

fyi I wanted to open a PR, but most likely to properly test it also prophecy (dev dep from this package) needs to get PHPUnit 10 support first. Looks like they're already working on it via phpspec/prophecy#585
@michalbundyra
Copy link
Member

@herndlm thanks, I've seen it already, was thinking about dropping prophecy here, there are going to be more issues in general here, so I am even tempted to support only PHPUnit 10 (or 9 and 10) in next minor release to clean up this package a bit. It's horrible mess atm.

@michalbundyra
Copy link
Member

@herndlm instead of waiting for prophecy to get PHPUnit 10 support I've tried with mockery as the second mocking library in our tests - and it seems to be successful. PHPUnit 10 support has been provided in PR #56 and just released in 2.7.0.

Any feedback appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@herndlm @michalbundyra