Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The warning tags lose their ids on front #152

Open
mmalferov opened this issue Sep 3, 2024 · 2 comments
Open

The warning tags lose their ids on front #152

mmalferov opened this issue Sep 3, 2024 · 2 comments

Comments

@mmalferov
Copy link
Member

I'm not sure if this issue is relevant php.net/manual or should I write only about php.net here

Both the
reference/event/eventbase.xml

and

language/types/float.xml

contains xml:id attribute in XML, but lose ids on front:

https://www.php.net/manual/en/language.types.float.php#warn.float-precision

https://www.php.net/manual/en/class.eventbase.php#eventbase.object-dtor-warning

The page content has no id attribute

@mmalferov mmalferov changed the title The warning tags lose their ids The warning tags lose their ids on front Sep 3, 2024
@jimwins jimwins transferred this issue from php/web-php Sep 3, 2024
@jimwins
Copy link
Member

jimwins commented Sep 3, 2024

This is actually a problem in phd, which is the tool that converts the documentation from XML to HTML, specifically the format_warning() (and format_warning_title()) function in phpdotnet/phd/Package/PEAR/XHTML.php.

(I've transferred the issue to the correct repository, reporting it to web-php was fine!)

@haszi
Copy link
Contributor

haszi commented Sep 7, 2024

Unfortunately there is a lot of different types of tags that don't render ID's from their respective xml:ids. Maybe we can investigate a generalized way to add these while letting the existing rendering methods override it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants