Review and potentially replace empty() checks for sdesc and ldesc

[lhsazevedo]

This is a follow up to a comment in #154

Background

There are a few cases where empty() is used to check sdesc (short description) and ldesc (long description) values. We need to verify if these checks are appropriate, considering that empty() checks for both unset and falsey values (including empty strings and "0").

Objective

Review the current usage of empty() for sdesc and ldesc, and determine if more precise string comparisons can be used.

Affected Files and Lines

At the moment of writing, there are at least three occurrences:

phd/phpdotnet/phd/Index.php

Line 360 in 417b066

if (empty($this->nfo[$this->currentid]["ldesc"])) {

phd/phpdotnet/phd/Index.php

Line 372 in 417b066

if (empty($this->nfo[$this->currentid]["sdesc"])) {

phd/phpdotnet/phd/Package/PEAR/Web.php

Line 77 in 417b066

empty($sdesc) ? $ldesc : $sdesc

Tasks

1. Verify the current behavior:

   • Confirm how sdesc and ldesc are initialized and used in the codebase.
   • Determine if there are cases where these entries could be unset or contain intentional falsey "0".

2. Based on findings, decide on the appropriate action:

   • If empty() is the correct check, document why it's appropriate in these cases.
   • If a more precise can be used, implement changes (e.g., using $var === "" for strict empty string checks).

3. Ensure consistency across the codebase in how these variables are handled.

References

• empty
• Converting to a boolean

---

Feel free to provide updates and seek clarification if needed during the investigation and implementation process.

[cmb69]

Maybe we should employ some static analyzer for the code base (not only for this issue)?