-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext/mysqli: Skip test that needs superuser #17531
base: master
Are you sure you want to change the base?
Conversation
This test needs CREATE DATABASE and CREATE SERVER, and will fail in the cleanup step if it doesn't have it. If the test is running as a user that can't do these, then we should skip instead of borking. Alternative to phpGH-17466.
Can you explain why is useful to run the tests with a user who doesn't have the full permissions? What does it accomplish? |
Setting up a CI environment that isn't (yet) containerized; see GH-17258. Because of that, I'm a little hesitant to grant the CI DB user more than all privileges on a specific DB. That said, maybe |
Co-authored-by: Kamil Tekiela <[email protected]>
Co-authored-by: Kamil Tekiela <[email protected]>
Even if it's not containerized, you'd want to be only ever running it on a test system. If for some reason, you still can't provide full permissions, then it is ok for some tests to fail as it points out flaws in the CI setup. We need full permissions in CI and if we don't have it then it means it's not set up correctly. I'm still not convinced that we want to modify this test file. |
This test needs CREATE DATABASE and CREATE SERVER, and will fail in the cleanup step if it doesn't have it. If the test is running as a user that can't do these, then we should skip instead of borking.
Alternative to GH-17466.