Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review usage of forced casts in extensions #32

Open
Girgias opened this issue Aug 8, 2024 · 0 comments
Open

Review usage of forced casts in extensions #32

Girgias opened this issue Aug 8, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed implementation

Comments

@Girgias
Copy link
Member

Girgias commented Aug 8, 2024

A lot of our extensions use convert_to_*() and zval_get_TYPE() engine functions which might hide some implicit casts to the end users.

Ideally, those usages should be reviewed and use the corresponding try function when available.
@Girgias Girgias added good first issue Good for newcomers help wanted Extra attention is needed implementation labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Girgias