-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIE installable with Composer? #136
Comments
I think it would be really nice. This way, if one day Pie allows to read from It would be so convenient to arrive on a project, and do
On the different projects I worked on, it's quite often that devs doesn't install Composer globally. I can understand that, some people like to have their projects a bit siloed without having to install tools globally on their system. In my opinion, having the choice is a good thing. |
IMO pie must be executed before the composer because the composer checks if all extension is installed. |
+1 for this; especially on local environments I can see the benefits of this, as then
Theoretically with this, you could do the following oneliner (untested) to first install
Also: adding |
If we make Pie installable by composer it would make sense to make Pie independent to any PHP extension. Otherwise, you could get into a paradox where you would like to install PIe for an extension but composer does not let you because Pie needs this extension as well. So, I would suggest to try and replace any extensions using polyfills. I could help on this. Running
|
I don't think any polyfills are needed. You should exclude dev dependencies; and it also helps to understand why certain extensions are needed, e.g.:
pcre is a core extension anyway, and ctype and openssl are bundled extensions, which are typically included in distributions anyway. I have kept external dependencies to a minimum for exactly this reason anyway. |
Split from: #98 (comment)
Should PIE be installable with Composer?
Points to note:
php/pie
is the namespace; I believe this is a protected namespace on Packagist, so I would need to discuss with Packagist team about submitting thiscomposer require php/pie
(per project) which doesn't make any sense to doCurrently the only supported distribution mechanism is downloading the PHAR from the https://github.com/php/pie/releases page. Other distribution mechanisms should be carefully evaluated on a case-by-case basis.
The text was updated successfully, but these errors were encountered: