New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for psr/log 2.0 and 3.0 #61

Open

Teddytrombone wants to merge 1 commit into phpactor:master from Teddytrombone:psr-log-more-versions

Teddytrombone commented Aug 29, 2024 •

edited

Loading

Fixes #60
There are some caveats:

as Psr\Log\Test\TestLogger was removed with psr/log:3.0 we need an alternative TestLogger for unit testing. colinodell/psr-testlogger provides this, which works for all psr/log versions.
we need to ignore phpstan errors in bin/serve.php as the inline class inheriting AbstractLogger needs more type hints depending on the psr/log version

Apart from that everything should work. phpunit and phpstan ran without errors.


          Add support for psr/log 2.0 and 3.0

ed8643f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet