Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap dependency fastapi to fastapi-slim #392

Closed
metakot opened this issue May 7, 2024 · 3 comments
Closed

Swap dependency fastapi to fastapi-slim #392

metakot opened this issue May 7, 2024 · 3 comments

Comments

@metakot
Copy link

metakot commented May 7, 2024

So the author of fastapi makes this really unwanted change. See fastapi/fastapi#11522
Some authors (like this) already did the rollback, maybe we too?

@dantownsend
Copy link
Member

I think for Piccolo Admin, using fastapi-slim is sufficient, so makes sense to change it.

@metakot
Copy link
Author

metakot commented Aug 5, 2024

The horonable sir of FastAPI did the [standard] optional dependencies. Issue resolved :)

@metakot metakot closed this as completed Aug 5, 2024
@dantownsend
Copy link
Member

Cool, thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants