From 4e72f69df61bec399896cb3de5aeeb1efded740f Mon Sep 17 00:00:00 2001
From: Manuel Kress <6232639+windaishi@users.noreply.github.com>
Date: Fri, 19 Jan 2024 20:36:41 +0100
Subject: [PATCH] Support single line multi value array in array destructing

---
 .../Sniffs/Arrays/ArrayDeclarationSniff.php       | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/php/php-codesniffer-standard/VIISON/Sniffs/Arrays/ArrayDeclarationSniff.php b/php/php-codesniffer-standard/VIISON/Sniffs/Arrays/ArrayDeclarationSniff.php
index 491bd3d..00c1392 100644
--- a/php/php-codesniffer-standard/VIISON/Sniffs/Arrays/ArrayDeclarationSniff.php
+++ b/php/php-codesniffer-standard/VIISON/Sniffs/Arrays/ArrayDeclarationSniff.php
@@ -228,8 +228,15 @@ public function processSingleLineArray($phpcsFile, $stackPtr, $arrayStart, $arra
                 $nestedParenthesis = array_pop($nested);
             }
 
-            if ($nestedParenthesis === false
-                || $tokens[$nestedParenthesis]['line'] !== $tokens[$stackPtr]['line']
+            // Decide whether this array is used for array destructing ( [$a, $b] = foo() )
+            $nextTokenThatIsNotEqual = $phpcsFile->findNext([T_EQUAL, T_WHITESPACE], $arrayEnd + 1, null, true);
+            $isArrayDestructing = $phpcsFile->findNext(T_EQUAL,  $arrayEnd + 1, $nextTokenThatIsNotEqual) !== false;
+
+            if (!$isArrayDestructing
+                && (
+                    $nestedParenthesis === false
+                    || $tokens[$nestedParenthesis]['line'] !== $tokens[$stackPtr]['line']
+                )
             ) {
                 $error = 'Array with multiple values cannot be declared on a single line';
                 $fix   = $phpcsFile->addFixableError($error, $stackPtr, 'SingleLineNotAllowed');
@@ -243,7 +250,7 @@ public function processSingleLineArray($phpcsFile, $stackPtr, $arrayStart, $arra
                 return;
             }
 
-            // We have a multiple value array that is inside a condition or
+            // We have a multiple value array that is an array destructing or inside a condition or
             // function. Check its spacing is correct.
             foreach ($commas as $comma) {
                 if ($tokens[($comma + 1)]['code'] !== T_WHITESPACE) {
@@ -352,7 +359,7 @@ public function processMultiLineArray($phpcsFile, $stackPtr, $arrayStart, $array
             // Skip bracketed statements, like function calls.
             if ($tokens[$nextToken]['code'] === T_OPEN_PARENTHESIS
                 && (isset($tokens[$nextToken]['parenthesis_owner']) === false
-                || $tokens[$nextToken]['parenthesis_owner'] !== $stackPtr)
+                    || $tokens[$nextToken]['parenthesis_owner'] !== $stackPtr)
             ) {
                 $nextToken = $tokens[$nextToken]['parenthesis_closer'];
                 continue;