Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Version that uses BigInt #22

Open
Daniel15 opened this issue Jul 27, 2019 · 2 comments · May be fixed by #24
Open

Version that uses BigInt #22

Daniel15 opened this issue Jul 27, 2019 · 2 comments · May be fixed by #24

Comments

@Daniel15
Copy link
Contributor

Daniel15 commented Jul 27, 2019 •
edited
Loading

It would be nice to get a version of this xxHash64 library that uses BigInt rather than the userland UInt64 implementation, in order to improve performance in environments that support BigInt. What do you think?
@pierrec
Copy link
Owner

pierrec commented Jul 27, 2019

Totally agree. Want to send a pull request?

@Daniel15
Copy link
Contributor Author

Sure, I can try to take a look. Will see if I can figure out a way to have a version that uses native bigints and another version that uses a userland implementation, without duplicating much code.

@Daniel15 Daniel15 linked a pull request Jul 28, 2019 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version of xxHash64 that uses native BigInt Daniel15/js-xxhash
2 participants
@Daniel15 @pierrec