Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate yamf-hash into own crate? #18

Closed
adzialocha opened this issue Jan 2, 2021 · 1 comment · Fixed by #20
Closed

Separate yamf-hash into own crate? #18

adzialocha opened this issue Jan 2, 2021 · 1 comment · Fixed by #20

Comments

@adzialocha
Copy link

yamf-hash follows its own separate specification and might be extended in the future (ongoing discussion here: AljoschaMeyer/bamboo#6). It is an interesting design choice as we can introduce new hashing algorithms without breaking bamboo.

To reflect the nature of yamf-hash I suggest separating the code from the bamboo one and give it its own crate?

@pietgeursen
Copy link
Owner

Yes! This has been on my todo list for ages and agree it should happen.
I'll add it as a thing to do before releasing 1.0 just so that I do actually to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants