Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String in french translation invalidates XML #90

Closed
WebnetMobile opened this issue Jul 25, 2014 · 4 comments
Closed

String in french translation invalidates XML #90

WebnetMobile opened this issue Jul 25, 2014 · 4 comments
Assignees
@pietrorampini
Labels
localization optimization
Milestone
m2.1.1

Comments

@WebnetMobile
Copy link

It's

<string name="downloadFor">Vérification d'une nouvelle mise à jour pour %1$s!\nDisponible dès maintenant sur %2$s.</string>

while it lacks escaping in d'un as it should be

<string name="downloadFor">Vérification d\'une nouvelle mise à jour pour %1$s!\nDisponible dès maintenant sur %2$s.</string>
@pietrorampini
Copy link
Owner

The apostrophe is already present.
See https://github.com/rampo/UpdateChecker/blob/master/library/src/main/res/values-fr/strings.xml

@pietrorampini pietrorampini self-assigned this Jul 25, 2014
@WebnetMobile
Copy link
Author

it is not present in recent stable - 2.1.0 -> https://github.com/rampo/UpdateChecker/releases/tag/v2.1.0 - so that release is faulty, and there's no 2.1.1 as far as I can see

@pietrorampini pietrorampini reopened this Jul 26, 2014
@pietrorampini
Copy link
Owner

You're right. I'll release 2.1.1 fixing this.

@pietrorampini pietrorampini added this to the m2.1.1 milestone Jul 27, 2014
@pietrorampini
Copy link
Owner

See release 2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietrorampini pietrorampini

Labels
localization optimization
Projects
None yet
Milestone
m2.1.1
Development

No branches or pull requests
2 participants
@pietrorampini @WebnetMobile