Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disable L1 labels when last datum not-in-view #352

Open
3 tasks
goodboy opened this issue Jul 6, 2022 · 0 comments
Open
3 tasks

Don't disable L1 labels when last datum not-in-view #352

goodboy opened this issue Jul 6, 2022 · 0 comments
Labels
graphics (charting related) geometry chops perf efficiency and latency optimization UI

Comments

@goodboy
Copy link
Contributor

goodboy commented Jul 6, 2022

I changed my mind on this since the downsampling magic landed in #302 😂
The latency for redraws of flows is now so low (and the coord caching seems to be working better on newer versions of Qt) that I think we can add this label update stuff back in.

It's actually pretty handy to see the current L1 spread on the y-axis when looking at history there's just some caveats we should ack and enforce:

  • obviously don't auto-scale the yrange to include the L1 / price when looking at history that is not in that range, i.e. the history range takes precedence

    • in the case where L1 is off-view, it'd be nice to have an indicator arrow pointing to where it is (top or bottom) much like we have for pp lines.
  • only pause the feed if panning on large data sets?

    • not sure this "optimization* is revelvant any more

    Probably pertains to HF feeds and UI performance via throttling #192, Fixing the convoluted ._set_yrange() callbacks mess #343

@goodboy goodboy added UI viz graphics (charting related) geometry chops perf efficiency and latency optimization labels Jul 6, 2022
@goodboy goodboy removed the viz label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphics (charting related) geometry chops perf efficiency and latency optimization UI
Projects
None yet
Development

No branches or pull requests

1 participant