Hip shot: try making low dpi "just work" #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm looks good on my machine |
|
@guilledk give that latest tip a shot. Pretty sure everything is resolved now 🏄🏼 |
goodboy
commented
Mar 31, 2021
| llabel.orient_v = orient_v | ||
| llabel.render() | ||
| llabel.show() | ||
| # # left side label |
There was a problem hiding this comment.
Yeah not convinced at all on these line labels minus the simple one for sizing. i'm thinkin we might want to swap out the contents labels with position and order info when order mode is engaged.
goodboy
commented
Apr 1, 2021
| margins = margins[0], ydim(font_size) | ||
| margins = margins[0], ydim(anchor_font_size) | ||
|
|
||
| print(f'margins: {margins}') |
iamzoltan
reviewed
Apr 1, 2021
|
@iamzoltan pretty much everything in the UI/UX should just scale around information. If you've used any decent software on mult-display gaming rigs you'll see that most good native apps just figure all this out for you and show a consistent "size in real world units" on screen - I think this is the way we should go from the outset. |
|
yea, that sounds like the most sane approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch more to do with this but figured I'd get it up so peeps can test.
So far most core devs and advanced users are working on hi dpi displays so HD has been mostly an afterthought.
This is a first draft/attempt at trying to make things "just work" when the auto-hidpi scaling doesn't seem to activate in minimal desktop linux envs (eg. i3 with no compositor).
This first bit of commits hacks font sizes depending on if a physical DPI of
<= 97is detected; in which case a smaller set of default font sizes are used.TODO:
potentially get some users to test with full linux desktop envs (like gnome3) to see if the built-in hi-dpi detection stuff from Qt works out of the boxdeferring to be part of DPI aware dynamic UI rescaling #159