Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Add coverage tools to Makefile #635

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

codysoyland
Copy link
Contributor

Overview

make cover-viz will now generate an HTML coverage report for the entire codebase.

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

`make cover-viz` will now generate an HTML coverage report for the
entire codebase.
@yuce
Copy link
Contributor

yuce commented Jun 13, 2017

Why do we run separate coverage for subpackages? Is there any difference from running it in the root?

@codysoyland
Copy link
Contributor Author

There does not appear to be a way to generate a coverage report for multiple packages with a single invocation of go test:

$ go test -coverprofile=coverage.out github.com/pilosa/pilosa github.com/pilosa/pilosa/cmd
cannot use test profile flag with multiple packages

Copy link
Contributor

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried make cover and make cover-viz and they work!

@codysoyland codysoyland merged commit 7f17b37 into FeatureBaseDB:master Jun 14, 2017
seebs pushed a commit to seebs/pilosa that referenced this pull request Nov 19, 2020
DetectMemAccessPastTx flag added, default false.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants