Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

add cluster config example to docs #806

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

jaffee
Copy link
Member

@jaffee jaffee commented Aug 31, 2017

Overview

We had some confusion over configuration - hopefully this will help to address it.

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

@jaffee jaffee requested a review from yuce August 31, 2017 21:44
Copy link
Contributor

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jaffee jaffee merged commit 34bb859 into FeatureBaseDB:master Sep 1, 2017
@jaffee jaffee deleted the config-example branch June 20, 2018 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants