Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Deprecate row/column labels #839

Merged
merged 4 commits into from
Sep 28, 2017
Merged

Conversation

yuce
Copy link
Contributor

@yuce yuce commented Sep 25, 2017

Overview

[Describe what this pull request addresses.]

Fixes #

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

@yuce yuce changed the title WIP: deprecate labels Deprecate row/column labels Sep 27, 2017
@jaffee
Copy link
Member

jaffee commented Sep 28, 2017

docs/getting-started.md still references a custom column label. (line 60)

@yuce
Copy link
Contributor Author

yuce commented Sep 28, 2017

@jaffee updated

@jaffee
Copy link
Member

jaffee commented Sep 28, 2017

It looks like the web UI still uses the labels feature - we should probably remove that to limit confusion.

@yuce
Copy link
Contributor Author

yuce commented Sep 28, 2017

Would it make sense to update webui in another PR?

@jaffee
Copy link
Member

jaffee commented Sep 28, 2017

That's fine with me.

@yuce yuce merged commit 066b36d into FeatureBaseDB:master Sep 28, 2017
@yuce yuce deleted the deprecate-labels branch September 28, 2017 16:23
seebs pushed a commit to seebs/pilosa that referenced this pull request Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants