This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Import field value #840
Merged
Import field value #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jaffee
approved these changes
Sep 27, 2017
client_test.go
Outdated
| @@ -286,6 +286,53 @@ func TestClient_ImportInverseEnabled(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Ensure client can bulk import value data. | |||
| func TestClient_Importalue(t *testing.T) { | |||
This PR adds the ability to import field values into RangeEnabled frames using the `pilosa import` command. Example: ``` pilosa import -i i -f f --field foo sample-vals.csv ``` imports data from sample-vals.csv, which contains data in the format: ``` [ColumnID, Value] ``` Also fixes a bug where `frame.rangeEnabled` was not being set on frame creation.
travisturner
force-pushed
the
import-field-value
branch
from
9e51e46 to
abc6bad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the ability to import FieldValue (BSI) data via the
pilosa importcommand.Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.