From 37a256ac6b6b66433e1d2626a6e6b39438ccc8d7 Mon Sep 17 00:00:00 2001 From: vitusortner Date: Sat, 23 May 2020 20:25:16 +0200 Subject: [PATCH 1/3] Get rid of unnecessary Flutter binding assertion in tests --- README.md | 2 -- example/test/main_test.dart | 2 -- floor/README.md | 2 -- floor/test/integration/blob/blob_test.dart | 2 -- floor/test/integration/boolean_conversions/bool_test.dart | 2 -- floor/test/integration/database_test.dart | 2 -- floor/test/integration/inheritance/dao_inheritance_test.dart | 2 -- floor/test/integration/stream_query_test.dart | 2 -- floor/test/integration/view/view_test.dart | 2 -- 9 files changed, 18 deletions(-) diff --git a/README.md b/README.md index 5c932fed..da95ae26 100644 --- a/README.md +++ b/README.md @@ -608,8 +608,6 @@ import 'database.dart'; import 'entity/person.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('database tests', () { TestDatabase database; PersonDao personDao; diff --git a/example/test/main_test.dart b/example/test/main_test.dart index b19f73c1..8e85f9bc 100644 --- a/example/test/main_test.dart +++ b/example/test/main_test.dart @@ -5,8 +5,6 @@ import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - FlutterDatabase database; TaskDao taskDao; diff --git a/floor/README.md b/floor/README.md index 5c932fed..da95ae26 100644 --- a/floor/README.md +++ b/floor/README.md @@ -608,8 +608,6 @@ import 'database.dart'; import 'entity/person.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('database tests', () { TestDatabase database; PersonDao personDao; diff --git a/floor/test/integration/blob/blob_test.dart b/floor/test/integration/blob/blob_test.dart index c8434144..1b275c9a 100644 --- a/floor/test/integration/blob/blob_test.dart +++ b/floor/test/integration/blob/blob_test.dart @@ -10,8 +10,6 @@ import 'package:sqflite/sqflite.dart' as sqflite; part 'blob_test.g.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('BLOB tests', () { TestDatabase database; PersonDao personDao; diff --git a/floor/test/integration/boolean_conversions/bool_test.dart b/floor/test/integration/boolean_conversions/bool_test.dart index faf6c0b2..80bd3155 100644 --- a/floor/test/integration/boolean_conversions/bool_test.dart +++ b/floor/test/integration/boolean_conversions/bool_test.dart @@ -8,8 +8,6 @@ import 'package:sqflite/sqflite.dart' as sqflite; part 'bool_test.g.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('Bool tests', () { TestDatabase database; BoolDao boolDao; diff --git a/floor/test/integration/database_test.dart b/floor/test/integration/database_test.dart index c486f7dd..b7f017d2 100644 --- a/floor/test/integration/database_test.dart +++ b/floor/test/integration/database_test.dart @@ -11,8 +11,6 @@ import 'model/dog.dart'; import 'model/person.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('database tests', () { TestDatabase database; PersonDao personDao; diff --git a/floor/test/integration/inheritance/dao_inheritance_test.dart b/floor/test/integration/inheritance/dao_inheritance_test.dart index 284f0ef0..51dd916e 100644 --- a/floor/test/integration/inheritance/dao_inheritance_test.dart +++ b/floor/test/integration/inheritance/dao_inheritance_test.dart @@ -8,8 +8,6 @@ import 'package:sqflite/sqflite.dart' as sqflite; part 'dao_inheritance_test.g.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('dao inheritance tests', () { TestDatabase database; PersonDao personDao; diff --git a/floor/test/integration/stream_query_test.dart b/floor/test/integration/stream_query_test.dart index 65626e6f..90ae27d0 100644 --- a/floor/test/integration/stream_query_test.dart +++ b/floor/test/integration/stream_query_test.dart @@ -6,8 +6,6 @@ import 'database.dart'; import 'model/person.dart'; void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('stream query tests', () { TestDatabase database; PersonDao personDao; diff --git a/floor/test/integration/view/view_test.dart b/floor/test/integration/view/view_test.dart index c69e9ca1..a200304e 100644 --- a/floor/test/integration/view/view_test.dart +++ b/floor/test/integration/view/view_test.dart @@ -28,8 +28,6 @@ abstract class ViewTestDatabase extends FloorDatabase { } void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - group('database tests', () { ViewTestDatabase database; PersonDao personDao; From b542b05dfe297ab57fff9292ef80f0ba69e1b272 Mon Sep 17 00:00:00 2001 From: vitusortner Date: Sat, 23 May 2020 20:34:19 +0200 Subject: [PATCH 2/3] Improve wording in README --- README.md | 2 +- floor/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index da95ae26..ac1d0e08 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ Floor provides a neat SQLite abstraction for your Flutter applications inspired by the [Room persistence library](https://developer.android.com/topic/libraries/architecture/room). It comes with automatic mapping between in-memory objects and database rows while still offering full control of the database with the use of SQL. -In order to harvest Floor's full potential, it's necessary to have an understanding of SQL and SQLite. +As a consequence, it's necessary to have an understanding of SQL and SQLite in order to harvest Floor's full potential. - typesafe - reactive diff --git a/floor/README.md b/floor/README.md index da95ae26..ac1d0e08 100644 --- a/floor/README.md +++ b/floor/README.md @@ -2,7 +2,7 @@ Floor provides a neat SQLite abstraction for your Flutter applications inspired by the [Room persistence library](https://developer.android.com/topic/libraries/architecture/room). It comes with automatic mapping between in-memory objects and database rows while still offering full control of the database with the use of SQL. -In order to harvest Floor's full potential, it's necessary to have an understanding of SQL and SQLite. +As a consequence, it's necessary to have an understanding of SQL and SQLite in order to harvest Floor's full potential. - typesafe - reactive From 0bc368e9c1d1f30596c7d6fb645ebfd55535edd5 Mon Sep 17 00:00:00 2001 From: vitusortner Date: Sat, 23 May 2020 20:38:18 +0200 Subject: [PATCH 3/3] Remove streamable views task form README --- README.md | 2 +- floor/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index ac1d0e08..32918e3a 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ As a consequence, it's necessary to have an understanding of SQL and SQLite in o - iOS, Android, Linux, macOS, Windows ⚠️ The library is on its way to its first stable release! -After integrating type converters, embeddable objects and streamable database views, the API surface won't change until after 1.0. +After integrating type converters and embeddable objects, the API surface won't change until after 1.0. [![pub package](https://img.shields.io/pub/v/floor.svg)](https://pub.dartlang.org/packages/floor) [![build status](https://github.com/vitusortner/floor/workflows/Continuous%20integration/badge.svg)](https://github.com/vitusortner/floor/actions) diff --git a/floor/README.md b/floor/README.md index ac1d0e08..32918e3a 100644 --- a/floor/README.md +++ b/floor/README.md @@ -13,7 +13,7 @@ As a consequence, it's necessary to have an understanding of SQL and SQLite in o - iOS, Android, Linux, macOS, Windows ⚠️ The library is on its way to its first stable release! -After integrating type converters, embeddable objects and streamable database views, the API surface won't change until after 1.0. +After integrating type converters and embeddable objects, the API surface won't change until after 1.0. [![pub package](https://img.shields.io/pub/v/floor.svg)](https://pub.dartlang.org/packages/floor) [![build status](https://github.com/vitusortner/floor/workflows/Continuous%20integration/badge.svg)](https://github.com/vitusortner/floor/actions)