show store location topology #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurine
commented
Aug 5, 2020
| children: TreeNode[] | ||
| } | ||
|
|
||
| function buildTopology(data: TopologyStoreLocation | undefined) { |
There was a problem hiding this comment.
It is easier to do the aggregation in the frontend, so I didn't do it in the backend.
|
Hi, @breeswish @HunDunDM please help take a look, thanks! the UI component to show the tree is WIP by the intern. |
breezewish
reviewed
Aug 5, 2020
|
Current effect:
TODO:
|
|
Good job! I suggest to assign different colors to distinguish a Label and an Instance. |
Got it! Final effect:
@breeswish PTAL, thanks! |
|
Changed colors for label and instance:
|
|
Very cool! |
breezewish
pushed a commit
that referenced
this pull request
Sep 8, 2020
(cherry picked from commit fb43f5b)
breezewish
added a commit
that referenced
this pull request
Sep 8, 2020
* feature: Query Editor (#713) * Backend: replace UNIX_TIMESTAMP with FROM_UNIXTIME in statement query (#731) * test: Stablize e2e tests (#732) * ui: Add store location tree (#728) * log_search: Display instance port (#722) * ui: show store location topology (#719) * ui: Online Config (#733) * ui: Support sharing session (#741) * doc: Update to sig-diagnosis (#742) * statement: Display number of plans in the list (#746) * log search: return zip instead of tar or gzip (#724)
|
How to create the test cluster: see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #688
API response example:
{ "location_labels": "zone,rack,host", "stores": [ { "address": "127.0.0.1:20160", "labels": { "host": "h1", "rack": "r1", "zone": "sh" } }, { "address": "127.0.0.1:20161", "labels": { "host": "h2", "rack": "r1", "zone": "sh" } }, { "address": "127.0.0.1:20162", "labels": { "host": "h1", "rack": "r1", "zone": "bj" } }, { "address": "127.0.0.1:3930", "labels": { "engine": "tiflash", "zone": "bj" } } ] }Aggregate to tree nodes:
{ "name": "zone", "value": "", "children": [ { "name": "zone", "value": "sh", "children": [ { "name": "rack", "value": "r1", "children": [ { "name": "host", "value": "h1", "children": [ { "name": "address", "value": "127.0.0.1:20160", "children": [] } ] }, { "name": "host", "value": "h2", "children": [ { "name": "address", "value": "127.0.0.1:20161", "children": [] } ] } ] } ] }, { "name": "zone", "value": "bj", "children": [ { "name": "rack", "value": "r1", "children": [ { "name": "host", "value": "h1", "children": [ { "name": "address", "value": "127.0.0.1:20162", "children": [] } ] } ] }, { "name": "address", "value": "127.0.0.1:3930", "children": [] } ] } ] }Currently, it is displayed in a new tab in the cluster-info page: