Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the install command to the helm 3.x version. #168

Merged
merged 1 commit into from Jan 22, 2020
Merged

Adapt the install command to the helm 3.x version. #168

merged 1 commit into from Jan 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2020

Fix the install command and some comments.
Until helm2 reached EOL,we would use the both helm version via 2.x and 3.x.

What problem does this PR solve?

fixes #165

What is changed and how does it work?

Add the install command with helm 3.x.

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Fix the install command and some comments.
Until helm2 reached EOL,
we would use the both helm version via 2.x and 3.x.
@zhouqiang-cl
Copy link
Contributor

/test

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@be757dd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #168   +/-   ##
=========================================
  Coverage          ?   39.86%           
=========================================
  Files             ?       17           
  Lines             ?      602           
  Branches          ?        0           
=========================================
  Hits              ?      240           
  Misses            ?      331           
  Partials          ?       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be757dd...c4c03a7. Read the comment docs.

@zhouqiang-cl zhouqiang-cl added contribution documentation Improvements or additions to documentation labels Jan 22, 2020
@zhouqiang-cl zhouqiang-cl requested review from mahjonp and you06 January 22, 2020 09:11
Copy link
Member

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit 9d62f1a into chaos-mesh:master Jan 22, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt the installation command via helm 3.X
3 participants