fix compile error on macos #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
test-on-macos
branch
from
779a900 to
13fd900
Compare
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 39.47% 39.47%
=======================================
Files 17 17
Lines 608 608
=======================================
Hits 240 240
Misses 337 337
Partials 31 31Continue to review full report at Codecov.
|
Signed-off-by: Yang Keao <[email protected]>
cwen0
reviewed
Feb 4, 2020
pkg/chaosdaemon/netem_darwin.go
Outdated
| @@ -0,0 +1,32 @@ | |||
| // Copyright 2019 PingCAP, Inc. | |||
Signed-off-by: Yang Keao <[email protected]>
cwen0
approved these changes
Feb 4, 2020
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* fix compile error on macos Signed-off-by: Yang Keao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Keao [email protected]
What problem does this PR solve?
This PR solves compile error on mac os. And hope to fix #167
What is changed and how does it work?
Now
handle.QdiscAdd,handle.QdiscDelandhandler.QdiscListare only used in_linux.gofiles.Check List
Tests
Wait for manual test from a macos user @cwen0 . New bugs may occure during test on macos.
Code changes