Add annotations in helm chart

[yeya24]

Signed-off-by: yeya24 [email protected]

What problem does this PR solve?

Fixes #200

What is changed and how does it work?

Check List

Tests

• Unit test
• E2E test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has Go code change
• Has CI related scripts change
• Has Terraform scripts change

Side effects

• Breaking backward compatibility

Related changes

• Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

[Yisaer]

Thanks for contributing. I think the job for pre-install and post-delete in helm chart templates may also need to expose the pod annotation configuration. The rest LGTM. @yeya24

[zhouqiang-cl]

Thank you for your contribution 😝

[zhouqiang-cl]

/ok-to-test

[codecov-io]

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   43.64%   43.64%           
=======================================
  Files          18       18           
  Lines         685      685           
=======================================
  Hits          299      299           
  Misses        353      353           
  Partials       33       33

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a9c60...b26ac91. Read the comment docs.

[yeya24]

Thanks for contributing. I think the job for pre-install and post-delete in helm chart templates may also need to expose the pod annotation configuration. The rest LGTM. @yeya24

Thanks for your review, do you mean that I need to add a new section in helm values.yaml to expose the annotations for the jobs? So what else fields I need to add in this section?

[Yisaer]

Thanks for contributing. I think the job for pre-install and post-delete in helm chart templates may also need to expose the pod annotation configuration. The rest LGTM. @yeya24

Thanks for your review, do you mean that I need to add a new section in helm values.yaml to expose the annotations for the jobs? So what else fields I need to add in this section?

Yes, we need to ensure the pod created by the job won't be injected sidecar with Istio. That's why we also need to annotate both two jobs. @yeya24

[Yisaer]

LGTM

[zhouqiang-cl]

@yeya24 have you test it, LGTM

[zhouqiang-cl]

@yeya24 has already test @Yisaer PTAL