Add prometheus in helm chart #230
Conversation
Signed-off-by: yeya24 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=========================================
Coverage ? 43.64%
=========================================
Files ? 18
Lines ? 685
Branches ? 0
=========================================
Hits ? 299
Misses ? 353
Partials ? 33Continue to review full report at Codecov.
|
| regex: (.*) | ||
| target_label: pod | ||
| replacement: $1 | ||
| action: replace |
There was a problem hiding this comment.
Maybe we can drop this label. Any idea about it?
There was a problem hiding this comment.
I dont. what about you @cwen0
There was a problem hiding this comment.
Maybe in the future, we will provide a multi-node way to deploy controller-manger, so I think it is ok to keep this label.
helm/chaos-mesh/values.yaml
Outdated
| @@ -96,6 +96,41 @@ dashboard: | |||
| storage: 3Gi | |||
| storageClassName: standard | |||
|
|
|||
| prometheus: | |||
| create: true | |||
There was a problem hiding this comment.
Can we set the default value to false?
| @@ -0,0 +1,95 @@ | |||
| apiVersion: apps/v1 | |||
There was a problem hiding this comment.
{{- if .Values.prometheus.create }}
| @@ -96,6 +96,41 @@ dashboard: | |||
| storage: 3Gi | |||
| storageClassName: standard | |||
|
|
|||
| prometheus: | |||
There was a problem hiding this comment.
I think prometheus is okay since it is just a single external component.
| @@ -0,0 +1,64 @@ | |||
| --- | |||
There was a problem hiding this comment.
{{- if .Values.prometheus.create }}
| @@ -0,0 +1,19 @@ | |||
| apiVersion: v1 | |||
Signed-off-by: yeya24 <[email protected]>
|
Updated. PTAL |
* add prometheus Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 [email protected]
What problem does this PR solve?
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: