Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CGOENV environment in Makefile #250

Merged
merged 5 commits into from
Feb 18, 2020
Merged

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Feb 17, 2020

Signed-off-by: cwen0 [email protected]

What problem does this PR solve?

What is changed and how does it work?

Add CGOENV environment in Makefile

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Signed-off-by: cwen0 <[email protected]>
zhouqiang-cl
zhouqiang-cl previously approved these changes Feb 17, 2020
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   47.96%   47.96%           
=======================================
  Files          23       23           
  Lines        1059     1059           
=======================================
  Hits          508      508           
  Misses        483      483           
  Partials       68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b49ec...199fb67. Read the comment docs.

@@ -14,9 +14,10 @@ endif

# Enable GO111MODULE=on explicitly, disable it with GO111MODULE=off when necessary.
export GO111MODULE := on
GOOS := $(if $(GOOS),$(GOOS),linux)
GOARCH := $(if $(GOARCH),$(GOARCH),amd64)
GOOS := $(if $(GOOS),$(GOOS),"")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member Author

cwen0 commented Feb 18, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 18, 2020

/run-all-tests

@sre-bot sre-bot merged commit 0b6aaab into chaos-mesh:master Feb 18, 2020
@cwen0 cwen0 deleted the update_makefile branch July 14, 2020 02:04
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants