-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CGOENV environment in Makefile #250
Conversation
Signed-off-by: cwen0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 47.96% 47.96%
=======================================
Files 23 23
Lines 1059 1059
=======================================
Hits 508 508
Misses 483 483
Partials 68 68 Continue to review full report at Codecov.
|
Signed-off-by: cwen0 <[email protected]>
@@ -14,9 +14,10 @@ endif | |||
|
|||
# Enable GO111MODULE=on explicitly, disable it with GO111MODULE=off when necessary. | |||
export GO111MODULE := on | |||
GOOS := $(if $(GOOS),$(GOOS),linux) | |||
GOARCH := $(if $(GOARCH),$(GOARCH),amd64) | |||
GOOS := $(if $(GOOS),$(GOOS),"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
Signed-off-by: cwen0 [email protected]
What problem does this PR solve?
What is changed and how does it work?
Add CGOENV environment in Makefile
Check List
Tests