Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timechaos doc #284

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix timechaos doc #284

merged 1 commit into from
Feb 25, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Feb 25, 2020

Signed-off-by: yeya24 [email protected]

What problem does this PR solve?

What is changed and how does it work?

Fix the example time chaos.

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: yeya24 <[email protected]>
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #284   +/-   ##
======================================
  Coverage    60.4%   60.4%           
======================================
  Files          36      36           
  Lines        1985    1985           
======================================
  Hits         1199    1199           
  Misses        692     692           
  Partials       94      94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e55e07...1386097. Read the comment docs.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit 2dc58db into chaos-mesh:master Feb 25, 2020
@yeya24 yeya24 deleted the fix-doc branch February 25, 2020 15:44
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants