Add Unit test in controllers/timechaos
#314
Conversation
|
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
|
@fewdan PLTA if the overall structure is ok, mainly about how |
|
@oraluben Thank you for your contribution. I think your structure is fine. |
|
/test |
|
@fewdan PTAL |
oraluben
changed the title
controllers/timechaoscontrollers/timechaos
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 60.34% 58.72% -1.62%
==========================================
Files 44 44
Lines 2890 2704 -186
==========================================
- Hits 1744 1588 -156
+ Misses 1026 1003 -23
+ Partials 120 113 -7
Continue to review full report at Codecov.
|
|
@lucklove PTAL too |
|
/merge |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| conn *grpc.ClientConn | ||
| } | ||
|
|
||
| func (c *GrpcChaosDaemonClient) Close() error { |
There was a problem hiding this comment.
exported method GrpcChaosDaemonClient.Close should have comment or be unexported
| conn *grpc.ClientConn | ||
| } | ||
|
|
||
| func (c *GrpcChaosDaemonClient) Close() error { |
There was a problem hiding this comment.
exported method GrpcChaosDaemonClient.Close should have comment or be unexported
| return nil, mockError("ContainerKill") | ||
| } | ||
|
|
||
| func (c *MockChaosDaemonClient) Close() error { |
There was a problem hiding this comment.
exported method MockChaosDaemonClient.Close should have comment or be unexported
|
/run-all-tests |
UCP #265
What problem does this PR solve?
#265
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: