Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrong pd iochaos example #347

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 17, 2020

Signed-off-by: yeya24 [email protected]

What problem does this PR solve?

The example yaml has a wrong volume name

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #347 into master will decrease coverage by 1.24%.
The diff coverage is 40.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   60.40%   59.15%   -1.25%     
==========================================
  Files          36       56      +20     
  Lines        1985     3249    +1264     
==========================================
+ Hits         1199     1922     +723     
- Misses        692     1177     +485     
- Partials       94      150      +56     
Impacted Files Coverage Δ
api/v1alpha1/iochaos_types.go 28.57% <0.00%> (-3.99%) ⬇️
api/v1alpha1/networkchaos_types.go 12.38% <0.00%> (-2.05%) ⬇️
api/v1alpha1/podchaos_types.go 21.87% <0.00%> (-10.69%) ⬇️
api/v1alpha1/timechaos_types.go 3.84% <0.00%> (-0.81%) ⬇️
controllers/kernelchaos_controller.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/netem_linux.go 17.50% <0.00%> (ø)
pkg/chaosdaemon/server.go 44.44% <0.00%> (ø)
pkg/utils/chaosdaemon.go 0.00% <0.00%> (ø)
pkg/utils/coalescer.go 0.00% <0.00%> (ø)
pkg/utils/graph.go 0.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7511e9e...87b2d41. Read the comment docs.

@sre-bot sre-bot merged commit 320ed6e into chaos-mesh:master Mar 18, 2020
@yeya24 yeya24 deleted the fix-pd-cm branch March 18, 2020 12:53
vincent178 pushed a commit to vincent178/chaos-mesh that referenced this pull request Mar 23, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants