Support helm3 in make install
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 61.00% 61.00%
=======================================
Files 56 56
Lines 3347 3347
=======================================
Hits 2042 2042
Misses 1145 1145
Partials 160 160 Continue to review full report at Codecov.
|
cwen0
reviewed
Mar 23, 2020
| @@ -98,7 +100,7 @@ run: generate fmt vet manifests | |||
| # Install CRDs into a cluster | |||
| install: manifests | |||
| kubectl apply -f manifests/crd.yaml | |||
| helm install helm/chaos-mesh --name=chaos-mesh --namespace=chaos-testing | |||
| bash -c '[[ `helm version --client --short` == "Client: v2"* ]] && helm install helm/chaos-mesh --name=chaos-mesh --namespace=chaos-testing || helm install chaos-mesh helm/chaos-mesh --namespace=chaos-testing;' | |||
There was a problem hiding this comment.
I see you have defined HELM_INSTALL, why don't you use it at here?
There was a problem hiding this comment.
Cleaned up. I was trying different way for conditional script in Makefile.
|
/merge |
|
Your auto merge job has been accepted, waiting for 369 |
|
/run-all-tests |
vincent178
pushed a commit
to vincent178/chaos-mesh
that referenced
this pull request
Mar 23, 2020
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Errors running
make installwhen helm version 3 is installedWhat is changed and how does it work?
Add support for helm 3
Check List
Tests
make installDoes this PR introduce a user-facing change?: