automatically calculate duration #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 56.93% 56.93%
=======================================
Files 60 60
Lines 3820 3820
=======================================
Hits 2175 2175
Misses 1471 1471
Partials 174 174 Continue to review full report at Codecov.
|
cwen0
reviewed
Mar 25, 2020
| @@ -285,11 +286,19 @@ func (r *Reconciler) applyContainer(ctx context.Context, client chaosdaemon.Chao | |||
| return err | |||
| } | |||
|
|
|||
| r.Log.Info("setting time shift", "mask", mask, "sec", chaos.Spec.TimeOffset.Sec, "nsec", chaos.Spec.TimeOffset.NSec) | |||
| duration, err := time.ParseDuration(chaos.Spec.TimeOffset) | |||
There was a problem hiding this comment.
split this logic to a single help function? So we can add the unit test for this.
cwen0
reviewed
Mar 25, 2020
| timeOffset: | ||
| sec: 100000 | ||
| nsec: 100000 | ||
| timeOffset: "-10m100ns" |
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
fewdan
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Keao [email protected]
What problem does this PR solve?
Calculate time chaos offset automatically.
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?:
Should use new form of
timeOffsetfield.