Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build dashboard-server-frontend in docker #377

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Build dashboard-server-frontend in docker #377

merged 2 commits into from
Mar 25, 2020

Conversation

Gallardot
Copy link
Member

What problem does this PR solve?

#376

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@Gallardot Gallardot mentioned this pull request Mar 24, 2020
Closed
zhouqiang-cl
zhouqiang-cl approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Mar 25, 2020

@Gallardot Does the Makefile need to be updated?

@Gallardot
Copy link
Member Author

@Gallardot Does the Makefile need to be updated?

@cwen0 I think it depends on CI/CD.

Our CI/CD pipeline just

make image
make docker-push

It works fine.

But If your CI/CD pipeline includes make dashboard-server-frontend. It will build the dashboard-server-frontend twice.

@cwen0
Copy link
Member

cwen0 commented Mar 25, 2020

@Gallardot Does the Makefile need to be updated?

@cwen0 I think it depends on CI/CD.

Our CI/CD pipeline just

make image
make docker-push

It works fine.

But If your CI/CD pipeline includes make dashboard-server-frontend. It will build the dashboard-server-frontend twice.

Got it.

cwen0
cwen0 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Mar 25, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 25, 2020

/run-all-tests

@sre-bot sre-bot merged commit b373c43 into chaos-mesh:master Mar 25, 2020
@Gallardot Gallardot deleted the yarn branch April 2, 2020 05:39
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
@Gallardot
Build dashboard-server-frontend in docker (chaos-mesh#377)
127735a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

Assignees
No one assigned
Labels
status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gallardot @cwen0 @sre-bot @zhouqiang-cl