Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically get kitware asc key #395

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

YangKeao
Copy link
Member

Signed-off-by: Yang Keao [email protected]

What problem does this PR solve?

Fix #392

Another change is to use official ubuntu mirror default (rather than aliyun mirror). The source address can be controled by environment variable UBUNTU_MIRROR.

Check List

Tests

  • Manual test

Signed-off-by: Yang Keao <[email protected]>
@YangKeao YangKeao requested a review from ethercflow March 31, 2020 08:22
@YangKeao YangKeao changed the title Dynamic get kitware asc key Dynamically get kitware asc key Mar 31, 2020
@YangKeao YangKeao requested a review from cwen0 March 31, 2020 08:24
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/test

@YangKeao YangKeao requested a review from fewdan March 31, 2020 08:38
@codecov-io
Copy link

Codecov Report

Merging #395 into master will decrease coverage by 1.82%.
The diff coverage is 50.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   60.40%   58.57%   -1.83%     
==========================================
  Files          36       60      +24     
  Lines        1985     3626    +1641     
==========================================
+ Hits         1199     2124     +925     
- Misses        692     1333     +641     
- Partials       94      169      +75     
Impacted Files Coverage Δ
api/v1alpha1/iochaos_types.go 32.55% <ø> (ø)
api/v1alpha1/podchaos_types.go 32.55% <ø> (ø)
api/v1alpha1/timechaos_types.go 4.34% <0.00%> (-0.31%) ⬇️
controllers/kernelchaos_controller.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/netlink_linux.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/server.go 44.44% <0.00%> (ø)
pkg/ptrace/ptrace_linux.go 65.92% <ø> (ø)
pkg/utils/coalescer.go 0.00% <0.00%> (ø)
pkg/utils/graph.go 0.00% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb9108...a722834. Read the comment docs.

Copy link
Member

@ethercflow ethercflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit b0769b7 into chaos-mesh:master Mar 31, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems the public key used in images/chaos-kernel/Dockerfile is unavailable
4 participants