Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: chaosfs pseudo random errno UT #398

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

Gallardot
Copy link
Member

What problem does this PR solve?

randomErrno is pseudo random function. It could be the same thing both times. Sometimes jenkins may report an error.

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

  • Has Go code change

Side effects

  • None

Related changes

  • None

Does this PR introduce a user-facing change?:

NONE

@codecov-io
Copy link

Codecov Report

Merging #398 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   60.87%   58.60%   -2.27%     
==========================================
  Files          61       60       -1     
  Lines        3798     3624     -174     
==========================================
- Hits         2312     2124     -188     
- Misses       1326     1331       +5     
- Partials      160      169       +9     
Impacted Files Coverage Δ
api/v1alpha1/iochaos_webhook.go 77.41% <0.00%> (-15.69%) ⬇️
api/v1alpha1/networkchaos_webhook.go 82.05% <0.00%> (-14.83%) ⬇️
api/v1alpha1/timechaos_webhook.go 77.41% <0.00%> (-11.77%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 77.41% <0.00%> (-7.77%) ⬇️
api/v1alpha1/timechaos_types.go 4.34% <0.00%> (-6.07%) ⬇️
api/v1alpha1/podchaos_webhook.go 81.25% <0.00%> (-3.50%) ⬇️
pkg/utils/selector.go 51.65% <0.00%> (-0.83%) ⬇️
api/v1alpha1/iochaos_types.go 32.55% <0.00%> (ø)
api/v1alpha1/common_webhook.go 100.00% <0.00%> (ø)
api/v1alpha1/podchaos_types.go 32.55% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d7527...01d47f3. Read the comment docs.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2020

/run-all-tests

@sre-bot sre-bot merged commit a5519ac into chaos-mesh:master Apr 2, 2020
@Gallardot Gallardot deleted the ci branch April 2, 2020 05:38
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants