Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e into CI #408

Merged
merged 19 commits into from
Apr 15, 2020
Merged

Add e2e into CI #408

merged 19 commits into from
Apr 15, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Apr 9, 2020

What problem does this PR solve?

Add e2e into ci

Does this PR introduce a user-facing change?:

NONE

@codecov-io
Copy link

codecov-io commented Apr 10, 2020 •
edited
Loading

Codecov Report

Merging #408 into master will increase coverage by 1.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   59.63%   60.79%   +1.16%     
==========================================
  Files          61       61              
  Lines        4003     3798     -205     
==========================================
- Hits         2387     2309      -78     
+ Misses       1446     1328     -118     
+ Partials      170      161       -9
Impacted Files Coverage Δ
api/v1alpha1/podchaos_types.go 32.55% <0.00%> (-6.51%) ⬇️
controllers/twophase/types.go 63.09% <0.00%> (-5.94%) ⬇️
controllers/iochaos_controller.go 90.47% <0.00%> (-4.77%) ⬇️
controllers/podchaos_controller.go 90.47% <0.00%> (-4.77%) ⬇️
controllers/networkchaos_controller.go 90.47% <0.00%> (-4.77%) ⬇️
api/v1alpha1/iochaos_types.go 32.55% <0.00%> (-4.37%) ⬇️
api/v1alpha1/networkchaos_types.go 18.93% <0.00%> (-2.74%) ⬇️
api/v1alpha1/timechaos_types.go 10.41% <0.00%> (-2.41%) ⬇️
api/v1alpha1/kernelchaos_types.go 4.65% <0.00%> (-1.15%) ⬇️
pkg/utils/selector.go 51.65% <0.00%> (-0.83%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0496466...db148ff. Read the comment docs.

@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@zhouqiang-cl
Copy link
Contributor

/test

@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@zhouqiang-cl
Copy link
Contributor

/test

@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 10, 2020

/run-e2e-test

2 similar comments
@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@mahjonp
Copy link
Contributor

mahjonp commented Apr 10, 2020

/run-e2e-test

@mahjonp
Copy link
Contributor

mahjonp commented Apr 10, 2020

/test

@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

2 similar comments
@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 10, 2020

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 15, 2020

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 15, 2020

/run-e2e-test

2 similar comments
@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 15, 2020

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 15, 2020

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 15, 2020

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 15, 2020

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Apr 15, 2020

/run-e2e-test

Yisaer
Yisaer commented Apr 15, 2020
View reviewed changes
ci/pingcap_chaos_mesh_build_kind.groovy
metadata:
labels:
# we pretend as tidb-operator in order not to meet tidb-operator-e2e job in the same node
app: tidb-operator-e2e
Copy link
Contributor Author

@Yisaer Yisaer Apr 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we would share same cluster with tidb-operator-e2e, so we pretend ourselves like tidb-operator-e2e in order not to run both kind of e2e job in one node.

@Yisaer Yisaer requested review from yeya24, zhouqiang-cl and cwen0 April 15, 2020 12:27
@Yisaer Yisaer removed the status/WIP label Apr 15, 2020
@Yisaer Yisaer changed the title [WIP] Add e2e into CI Add e2e into CI Apr 15, 2020
zhouqiang-cl
zhouqiang-cl previously approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fewdan
fewdan reviewed Apr 15, 2020
View reviewed changes
test/e2e/config/config.go Outdated Show resolved Hide resolved
@Yisaer Yisaer requested review from fewdan and zhouqiang-cl April 15, 2020 12:48
yeya24
yeya24 approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cwen0
cwen0 approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Apr 15, 2020

/merge

@cwen0
Copy link
Member

cwen0 commented Apr 15, 2020

/run-e2e-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

@Yisaer merge failed.

@cwen0
Copy link
Member

cwen0 commented Apr 15, 2020

/run-all-tests

@cwen0 cwen0 merged commit bdadbc8 into chaos-mesh:master Apr 15, 2020
@Yisaer Yisaer deleted the add_e2e_into_ci branch April 26, 2020 05:39
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
@Yisaer
Add e2e into CI (chaos-mesh#408)
65b4f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@cwen0 cwen0 cwen0 approved these changes

@fewdan fewdan Awaiting requested review from fewdan

@zhouqiang-cl zhouqiang-cl Awaiting requested review from zhouqiang-cl

Assignees
No one assigned
Labels
status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Yisaer @codecov-io @zhouqiang-cl @mahjonp @cwen0 @sre-bot @fewdan @yeya24