remove hook from helm chart #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
|
/run-e2e-test |
|
@Gallardot @yeya24 @fewdan PTAL |
Gallardot
reviewed
May 6, 2020
| @@ -1,3 +1,27 @@ | |||
| {{- $altNames := list ( printf "%s.%s.svc" (include "chaos-mesh.svc" .) .Release.Namespace ) }} | |||
| {{- $ca := genCA "chaos-mesh-ca" 3650 }} | |||
| {{- $cert := genSignedCert "chaos-mesh-ca" nil $altNames 3650 $ca }} | |||
There was a problem hiding this comment.
10 year？
Maybe we should also change the duration of Certificate
Signed-off-by: cwen0 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 58.57% 58.91% +0.34%
==========================================
Files 60 68 +8
Lines 3626 4379 +753
==========================================
+ Hits 2124 2580 +456
- Misses 1333 1606 +273
- Partials 169 193 +24
Continue to review full report at Codecov.
|
yeya24
reviewed
May 6, 2020
helm/chaos-mesh/README.md
Outdated
| @@ -71,7 +71,6 @@ The following tables list the configurable parameters of the Chaos Mesh chart an | |||
| | `preJobs.podAnnotations` | | `{}` | | |||
| | `postJobs.podAnnotations` | | `{}` | | |||
There was a problem hiding this comment.
Please also delete these two options since they are not used anymore.
Signed-off-by: cwen0 <[email protected]>
|
/run-e2e-test |
1 similar comment
|
/run-e2e-test |
|
Sorry about the flaky E2E, I think we can merge this first because the failed case is not related to this PR. WDYT? |
yeya24
approved these changes
May 6, 2020
Gallardot
approved these changes
May 6, 2020
|
/merge |
|
/run-all-tests |
|
@cwen0 merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cwen0 [email protected]
What problem does this PR solve?
Remove the hook and use
genCAto generate certsWhat is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: