Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #470

Merged
merged 9 commits into from
May 9, 2020
Merged

fix typo #470

merged 9 commits into from
May 9, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented May 8, 2020

What problem does this PR solve?

update document.

What is changed and how does it work?

update document.

Check List

Tests

  • No code

Code changes

  • NO

Side effects

  • NO

Related changes

  • NO

Does this PR introduce a user-facing change?:

NONE

@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #470 into master will increase coverage by 0.26%.
The diff coverage is 53.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   58.57%   58.83%   +0.25%     
==========================================
  Files          60       68       +8     
  Lines        3626     4385     +759     
==========================================
+ Hits         2124     2580     +456     
- Misses       1333     1612     +279     
- Partials      169      193      +24     
Impacted Files Coverage Δ
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/iochaos_types.go 31.11% <0.00%> (-1.45%) ⬇️
api/v1alpha1/kernelchaos_types.go 4.44% <0.00%> (-0.21%) ⬇️
api/v1alpha1/networkchaos_types.go 18.65% <0.00%> (-0.29%) ⬇️
api/v1alpha1/podchaos_types.go 31.11% <0.00%> (-1.45%) ⬇️
controllers/stresschaos_controller.go 0.00% <0.00%> (ø)
controllers/timechaos_controller.go 0.00% <0.00%> (ø)
controllers/twophase/types.go 55.78% <0.00%> (-7.31%) ⬇️
pkg/chaosdaemon/netem_linux.go 26.66% <0.00%> (-17.78%) ⬇️
pkg/chaosdaemon/netlink_linux.go 0.00% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df0492...1d80e5c. Read the comment docs.

cwen0
cwen0 previously approved these changes May 8, 2020
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24
Copy link
Contributor

yeya24 commented May 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

@fewdan merge failed.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented May 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 15ff111 into chaos-mesh:master May 9, 2020
@fewdan fewdan deleted the typo branch May 11, 2020 07:29
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants