Revise e2e port-forward function #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2020 20:23
|
/run-e2e-test |
|
/run-e2e-test |
yeya24
previously approved these changes
May 8, 2020
| return forwardedPorts, cancel, nil | ||
| } | ||
|
|
||
| // Forward would port-forward forward target resources |
There was a problem hiding this comment.
port-forward forward? Is port-forward a noun or a verb?
There was a problem hiding this comment.
just a typo fixed now.
|
/run-e2e-test |
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 58.57% 58.88% +0.30%
==========================================
Files 60 68 +8
Lines 3626 4385 +759
==========================================
+ Hits 2124 2582 +458
- Misses 1333 1611 +278
- Partials 169 192 +23
Continue to review full report at Codecov.
|
|
/run-e2e-test |
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add e2e port-forward utility function.
Does this PR introduce a user-facing change?: