-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StressChaos extension for more stress-ng options #515
Conversation
@huangwei2013 Thanks for your contribution, please sign CLA first. |
if in.CPUStressor.Options != nil { | ||
for _,v := range in.CPUStressor.Options{ | ||
stressors += fmt.Sprintf(" %v ", v) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about if user set the --cpu-load
option? How would we merge the adding option and the existed option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yiaser by stress-ng itself will take over the repeated options ( tested: later one will replace former one)
A test case is : ( --cpu is a more clear test case, Top to find there is only on Processor of "stress-ng-cpu ")
stress-ng --cpu-load 10 --cpu 2 --cpu 1
@huangwei2013 |
* MemoryStressor.Options set "omitempty" * CPUStressor.Options set "omitempty"
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
==========================================
- Coverage 61.39% 56.21% -5.19%
==========================================
Files 64 67 +3
Lines 4069 4307 +238
==========================================
- Hits 2498 2421 -77
- Misses 1383 1716 +333
+ Partials 188 170 -18
Continue to review full report at Codecov.
|
pause and start experiment by API (chaos-mesh#542)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
What problem does this PR solve?
metions issue #144 , a experimental intensify about how to make use of hundreds stress-ng options .
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: