-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to generate go code from proto files #519
Conversation
Signed-off-by: yeya24 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fewdan PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
- Coverage 61.39% 59.73% -1.66%
==========================================
Files 64 68 +4
Lines 4069 4406 +337
==========================================
+ Hits 2498 2632 +134
- Misses 1383 1579 +196
- Partials 188 195 +7
Continue to review full report at Codecov.
|
@yeya24 merge failed. |
Signed-off-by: yeya24 [email protected]
What problem does this PR solve?
Add a script to generate go code from proto files.
We can easily run it via
make proto