Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to generate go code from proto files #519

Merged
merged 2 commits into from
May 18, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented May 17, 2020

Signed-off-by: yeya24 [email protected]

What problem does this PR solve?

Add a script to generate go code from proto files.
We can easily run it via make proto

Signed-off-by: yeya24 <[email protected]>
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented May 18, 2020

@fewdan PTAL

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member

fewdan commented May 18, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 18, 2020

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #519 into master will decrease coverage by 1.65%.
The diff coverage is 44.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   61.39%   59.73%   -1.66%     
==========================================
  Files          64       68       +4     
  Lines        4069     4406     +337     
==========================================
+ Hits         2498     2632     +134     
- Misses       1383     1579     +196     
- Partials      188      195       +7     
Impacted Files Coverage Δ
api/v1alpha1/iochaos_types.go 48.93% <0.00%> (+17.82%) ⬆️
api/v1alpha1/kernelchaos_types.go 19.14% <0.00%> (+14.70%) ⬆️
api/v1alpha1/networkchaos_types.go 23.52% <0.00%> (+4.87%) ⬆️
api/v1alpha1/podchaos_types.go 44.68% <0.00%> (+13.56%) ⬆️
api/v1alpha1/timechaos_types.go 23.07% <0.00%> (+13.07%) ⬆️
controllers/kernelchaos_controller.go 0.00% <0.00%> (ø)
controllers/podchaos/types.go 65.95% <0.00%> (ø)
controllers/stresschaos_controller.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/netem_linux.go 26.66% <0.00%> (ø)
pkg/chaosdaemon/netlink_linux.go 0.00% <ø> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c5381...abc323c. Read the comment docs.

@sre-bot
Copy link
Contributor

sre-bot commented May 18, 2020

@yeya24 merge failed.

@cwen0 cwen0 merged commit b2eced7 into chaos-mesh:master May 18, 2020
@yeya24 yeya24 deleted the add-gen-proto-script branch May 18, 2020 15:04
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants