update store/event/event.go #526
Conversation
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 61.39% 56.03% -5.36%
==========================================
Files 64 66 +2
Lines 4069 4256 +187
==========================================
- Hits 2498 2385 -113
- Misses 1383 1700 +317
+ Partials 188 171 -17
Continue to review full report at Codecov.
|
pkg/apiserver/event/event.go
Outdated
| @@ -47,11 +51,45 @@ func NewService( | |||
|
|
|||
| // Register mounts our HTTP handler on the mux. | |||
| func Register(r *gin.RouterGroup, s *Service) { | |||
| endpoint := r.Group("/event") | |||
| endpoint := r.Group("/events") | |||
|
|
|||
| // TODO: add more api handlers | |||
| endpoint.GET("/all", s.listEvents) | |||
There was a problem hiding this comment.
We can use "endpoint.GET("l", s.listEvents)" here if this makes sense to you
There was a problem hiding this comment.
There is no modification here, I don't quite understand what you mean.
|
This pull request introduces 1 alert when merging 5331a28 into c762830 - view on LGTM.com new alerts:
|
pkg/apiserver/event/event.go
Outdated
| namespace := c.Query("namespace") | ||
| eventList := make([]*core.Event, 0) | ||
|
|
||
| if name == "" && namespace == "" { |
There was a problem hiding this comment.
Did we need to define a funtion like CheckNameAndNamespace(It can be done in other PR)
|
This pull request introduces 1 alert when merging 44ed01f into 13ea19f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 44ed01f into 13ea19f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 6e90930 into ce3afb7 - view on LGTM.com new alerts:
|
|
/merge |
|
/run-all-tests |
|
Umm, I don't know why this is still not merged even if the E2E is passed. Let me merge this manually. |
* events/all * update store/event * update * update StatusCode * address comment * address comment * address comment * address conflict * conflict * update events * fix typo * address comment * update url * address comment
What problem does this PR solve?
In order to implement event-related interfaces, store/event/event.go was completed.
What is changed and how does it work?
update store/event/event.go
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: