pause and start experiment by API #542
Conversation
Signed-off-by: cwen0 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 61.39% 56.28% -5.11%
==========================================
Files 64 67 +3
Lines 4069 4301 +232
==========================================
- Hits 2498 2421 -77
- Misses 1383 1710 +327
+ Partials 188 170 -18
Continue to review full report at Codecov.
|
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
There was a problem hiding this comment.
Looks good. Just some small nits.
BTW, do you mind updating the deleteExperiment swagger in this PR? Seems I forgot to include the failure 404
// @Success 200 "delete ok"
// @Router /api/experiments/{kind}/{namespace}/{name} [delete]
// @Failure 400 {object} utils.APIError
// @Failure 500 {object} utils.APIError
func (s *Service) deleteExperiment(c *gin.Context) {
|
|
||
| // ChaosKindMap defines a map including all chaos kinds. | ||
| type chaosKindMap struct { | ||
| sync.RWMutex |
There was a problem hiding this comment.
This is a map, so I think it is necessary
| for key, kind := range c.kinds { | ||
| out[key] = &ChaosKind{ | ||
| Chaos: kind.Chaos.DeepCopyObject(), | ||
| ChaosList: kind.ChaosList, |
There was a problem hiding this comment.
I am not sure whether DeepCopyObject() is necessary or not. If it is, ChaosList also supports this method. kind.ChaosList.DeepCopyObject()
There was a problem hiding this comment.
OK, DeepCopyObject() is not necessary and I have removed it.
| // @Param name path string true "name" | ||
| // @Success 200 "start ok" | ||
| // @Failure 500 {object} utils.APIError | ||
| // @Failure 404 {object} utils.APIError |
| // @Success 200 "start ok" | ||
| // @Failure 500 {object} utils.APIError | ||
| // @Failure 404 {object} utils.APIError | ||
| // @Router /api/experiments/start/{kind}/{ns}/{name} [put] |
There was a problem hiding this comment.
// @Router /api/experiments/start/{kind}/{namespace}/{name} [put]
| // @Param name path string true "name" | ||
| // @Success 200 "pause ok" | ||
| // @Failure 500 {object} utils.APIError | ||
| // @Failure 404 {object} utils.APIError |
|
|
||
| // ExperimentBase is used to identify the unique experiment from API request. | ||
| type ExperimentBase struct { | ||
| Kind string `uri:"kind" binding:"required,oneof=PodChaos NetworkChaos IoChaos StressChaos TimeChaos"` |
| endpoint.GET("/detail/:namespace/:name", s.getExperimentDetail) | ||
| endpoint.DELETE("/:kind/:namespace/:name", s.deleteExperiment) | ||
| endpoint.GET("/detail/:kind/:namespace/:name", s.getExperimentDetail) | ||
| endpoint.DELETE("/delete/:kind/:namespace/:name", s.deleteExperiment) |
There was a problem hiding this comment.
IMO /delete/:kind/:namespace/:name is not needed, do you mind changing this to /:kind/:namespace/:name? We are already using the DELETE verb here.
Signed-off-by: cwen0 <[email protected]>
|
/run-e2e-test |
1 similar comment
|
/run-e2e-test |
|
/run-e2e-test |
|
/merge |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -600,3 +609,111 @@ func (s *Service) state(c *gin.Context) { | |||
|
|
|||
| c.JSON(http.StatusOK, data) | |||
| } | |||
|
|
|||
| // ExperimentBase is used to identify the unique experiment from API request. | |||
| type ExperimentBase struct { | |||
There was a problem hiding this comment.
type name will be used as experiment.ExperimentBase by other packages, and that stutters; consider calling this Base
|
/run-all-tests |
|
@cwen0 merge failed. |
|
/run-e2e-tests |
pause and start experiment by API (chaos-mesh#542)
Signed-off-by: cwen0 [email protected]
What problem does this PR solve?
#370
We need to support pause and start chaos experiment by API.