Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StressChaos CRD #551

Merged
merged 1 commit into from
May 25, 2020
Merged

Fix StressChaos CRD #551

merged 1 commit into from
May 25, 2020

Conversation

Gallardot
Copy link
Member

What problem does this PR solve?

legacy #515 , we should also update the crd and zz_generated.deepcopy.go

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@Gallardot Gallardot changed the title fix StressChaos crd Fix StressChaos CRD May 25, 2020
@Gallardot
Copy link
Member Author

/run-e2e-test

@codecov-commenter
Copy link

Codecov Report

Merging #551 into master will decrease coverage by 5.22%.
The diff coverage is 40.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   61.39%   56.16%   -5.23%     
==========================================
  Files          64       67       +3     
  Lines        4069     4307     +238     
==========================================
- Hits         2498     2419      -79     
- Misses       1383     1717     +334     
+ Partials      188      171      -17     
Impacted Files Coverage Δ
controllers/kernelchaos_controller.go 0.00% <0.00%> (ø)
controllers/podchaos/types.go 65.95% <0.00%> (ø)
controllers/stresschaos_controller.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/netem_linux.go 26.66% <0.00%> (ø)
pkg/chaosdaemon/netlink_linux.go 0.00% <ø> (ø)
pkg/chaosdaemon/stress_server_linux.go 0.00% <0.00%> (ø)
pkg/utils/chaosdaemon.go 51.21% <ø> (ø)
pkg/webhook/config/config.go 17.14% <ø> (-72.86%) ⬇️
pkg/webhook/config/watcher/config.go 41.66% <ø> (-58.34%) ⬇️
pkg/webhook/config/watcher/util.go 75.00% <ø> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a380075...adead70. Read the comment docs.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented May 25, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 25, 2020

/run-all-tests

@sre-bot sre-bot merged commit af9551b into chaos-mesh:master May 25, 2020
@Gallardot Gallardot deleted the fix-crd branch May 25, 2020 07:49
@Gallardot Gallardot mentioned this pull request May 25, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants