Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API]add experiment detail #564

Merged
merged 18 commits into from
May 29, 2020
Merged

[API]add experiment detail #564

merged 18 commits into from
May 29, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented May 27, 2020

What problem does this PR solve?

add experiment detail

What is changed and how does it work?

add experiment detail

Check List

Tests

  • No code

Code changes

  • Has Go code change

Side effects

  • NO

Related changes

  • NO

Does this PR introduce a user-facing change?:

NONE

@fewdan fewdan linked an issue May 27, 2020 that may be closed by this pull request
[API] Get detailed information about the given experiment #493
Closed
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #564 into master will decrease coverage by 0.19%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
- Coverage   55.98%   55.79%   -0.20%     
==========================================
  Files          67       68       +1     
  Lines        4324     4380      +56     
==========================================
+ Hits         2421     2444      +23     
- Misses       1733     1765      +32     
- Partials      170      171       +1
Impacted Files Coverage Δ
api/v1alpha1/iochaos_types.go 40.00% <ø> (ø)
controllers/iochaos_controller.go 85.71% <ø> (ø)
pkg/webhook/config/config.go 17.14% <ø> (ø)
pkg/store/experiment/experiment.go 38.77% <45.23%> (ø)
controllers/twophase/types.go 55.88% <74.07%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18660df...60609d0. Read the comment docs.

yeya24
yeya24 previously approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, only a small nit

pkg/apiserver/experiment/experiment.go Show resolved Hide resolved
yeya24
yeya24 approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member Author

fewdan commented May 28, 2020

/run-e2e-test

@fewdan
Copy link
Member Author

fewdan commented May 28, 2020

/run-e2e-test

1 similar comment
@fewdan
Copy link
Member Author

fewdan commented May 29, 2020

/run-e2e-test

cwen0
cwen0 approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0 cwen0 merged commit 0d57f73 into chaos-mesh:master May 29, 2020
@fewdan fewdan deleted the experiment_detail branch May 29, 2020 07:00
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
@fewdan
[API]add experiment detail (chaos-mesh#564)
2851079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] Get detailed information about the given experiment
4 participants
@fewdan @codecov-commenter @cwen0 @yeya24